Fix LSP Crash in Code Fences #493
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d... under same circumstances as before
|
Great, thanks for this!! There's been a lot of activity here all of sudden, and I'm a little down on free time at the moment. So just a heads up that I may take a bit to get around to this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the crash described in #461.
As of right now, the behavior that previously causes the crash can cause the LSP diagnostics to switch running diagnostics inside fenced areas (instead of outside see:
test-zone.md).While this is still undefined behavior, it is better than crashing the LSP client.
It seems to me that the logic behind when to check the links may need a major refactor in order to fix this bug, so in the mean time, we can add this as a quick fix.
Testing:
I tested this on the following files:
test-note.md
test-zone.md
empty.md
The Diagnostics switch
On Open
After Triggering the Bug